Fixes #97906: Do not classify user installed extensions as built-in e…

…xtensions
microsoft · Nov 18, 2020 · 334ede7 · 334ede7
1 parent 4f61f6d
commit 334ede7
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/src/vs/platform/keybinding/common/keybindingResolver.ts b/src/vs/platform/keybinding/common/keybindingResolver.ts
@@ -383,14 +383,9 @@ function printWhenExplanation(when: ContextKeyExpression | undefined): string {
 }
 
 function printSourceExplanation(kb: ResolvedKeybindingItem): string {
-	if (kb.isDefault) {
-		if (kb.extensionId) {
-			return `built-in extension ${kb.extensionId}`;
-		}
-		return `built-in`;
-	}
-	if (kb.extensionId) {
-		return `user extension ${kb.extensionId}`;
-	}
-	return `user`;
+	return (
+		kb.extensionId
+			? (kb.isBuiltinExtension ? `built-in extension ${kb.extensionId}` : `user extension ${kb.extensionId}`)
+			: (kb.isDefault ? `built-in` : `user`)
+	);
 }