Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
andreamah committed Feb 7, 2023
1 parent 7b97332 commit 349b100
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 7 deletions.
Expand Up @@ -22,6 +22,7 @@ export interface INotebookEditorService {
_serviceBrand: undefined;

retrieveWidget(accessor: ServicesAccessor, group: IEditorGroup, input: NotebookEditorInput, creationOptions?: INotebookEditorCreationOptions, dimension?: Dimension): IBorrowValue<INotebookEditor>;

retrieveExistingWidgetFromURI(resource: URI): IBorrowValue<NotebookEditorWidget> | undefined;
retrieveAllExistingWidgets(): IBorrowValue<NotebookEditorWidget>[];
onDidAddNotebookEditor: Event<INotebookEditor>;
Expand Down
1 change: 0 additions & 1 deletion src/vs/workbench/contrib/search/browser/replaceService.ts
Expand Up @@ -220,7 +220,6 @@ export class ReplaceService implements IReplaceService {

private createEdit(match: Match, text: string, resource: URI | null = null): ResourceTextEdit {
const fileMatch: FileMatch = match.parent();

return new ResourceTextEdit(
resource ?? fileMatch.resource,
{ range: match.range(), text }, undefined, undefined
Expand Down
6 changes: 1 addition & 5 deletions src/vs/workbench/contrib/search/browser/searchModel.ts
Expand Up @@ -515,9 +515,7 @@ export class FileMatch extends Disposable implements IFileMatch {
}

matches(): Match[] {
const vals = this._matches.values();
const arr = Array.from(vals);
return arr;
return Array.from(this._matches.values());
}

remove(matches: Match | Match[]): void {
Expand Down Expand Up @@ -1769,7 +1767,6 @@ export class SearchModel extends Disposable {
};
}


private async doSearch(query: ITextQuery, progressEmitter: Emitter<void>, searchQuery: ITextQuery, onProgress?: (result: ISearchProgressItem) => void) {
const tokenSource = this.currentCancelTokenSource = new CancellationTokenSource();
const onProgressCall = (p: ISearchProgressItem) => {
Expand All @@ -1788,7 +1785,6 @@ export class SearchModel extends Disposable {
);
tokenSource.dispose();
return { ...currentResult, ...notebookResult };

}

async search(query: ITextQuery, onProgress?: (result: ISearchProgressItem) => void): Promise<ISearchComplete> {
Expand Down
1 change: 0 additions & 1 deletion src/vs/workbench/contrib/search/browser/searchView.ts
Expand Up @@ -553,7 +553,6 @@ export class SearchView extends ViewPane {
}

refreshTree(event?: IChangeEvent): void {
// animation frame and debounce
const collapseResults = this.searchConfig.collapseResults;
if (!event || event.added || event.removed) {
// Refresh whole tree
Expand Down

0 comments on commit 349b100

Please sign in to comment.