Skip to content

Commit

Permalink
Fix bug causing workspace recommendations to go away upon ignoring a …
Browse files Browse the repository at this point in the history
…recommendation (#55805)

* Fix bug causing workspace recommendations to go away upon ignoring a recommendation

* ONly show on @recommended or @recommended:workspace

* Make more consistant
  • Loading branch information
Jackson Kearl authored and ramya-rao-a committed Aug 6, 2018
1 parent 35f7ed7 commit 3ffdfae
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,8 @@ export class WorkspaceRecommendedExtensionsView extends ExtensionsListView {
}

async show(query: string): Promise<IPagedModel<IExtension>> {
let model = await ((query && query.trim() !== '@recommended') ? this.showEmptyModel() : super.show(this.recommendedExtensionsQuery));
let shouldShowEmptyView = query && query.trim() !== '@recommended' && query.trim() !== '@recommended:workspace';
let model = await (shouldShowEmptyView ? this.showEmptyModel() : super.show(this.recommendedExtensionsQuery));
this.setExpanded(model.length > 0);
return model;
}
Expand Down

0 comments on commit 3ffdfae

Please sign in to comment.