Skip to content

Commit

Permalink
checkbox api event naming change (#161131)
Browse files Browse the repository at this point in the history
  • Loading branch information
benibenj committed Sep 16, 2022
1 parent 6e8bc02 commit 42e8544
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions src/vs/workbench/api/common/extHostTreeViews.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class ExtHostTreeViews implements ExtHostTreeViewsShape {
get onDidChangeSelection() { return treeView.onDidChangeSelection; },
get visible() { return treeView.visible; },
get onDidChangeVisibility() { return treeView.onDidChangeVisibility; },
get onDidChangeTreeCheckbox() { checkProposedApiEnabled(extension, 'treeItemCheckbox'); return treeView.onDidChangeTreeCheckbox; },
get onDidChangeCheckboxState() { checkProposedApiEnabled(extension, 'treeItemCheckbox'); return treeView.onDidChangeCheckboxState; },
get message() { return treeView.message; },
set message(message: string) {
treeView.message = message;
Expand Down Expand Up @@ -306,8 +306,8 @@ class ExtHostTreeView<T> extends Disposable {
private _onDidChangeVisibility: Emitter<vscode.TreeViewVisibilityChangeEvent> = this._register(new Emitter<vscode.TreeViewVisibilityChangeEvent>());
readonly onDidChangeVisibility: Event<vscode.TreeViewVisibilityChangeEvent> = this._onDidChangeVisibility.event;

private _onDidChangeTreeCheckbox = this._register(new Emitter<vscode.TreeCheckboxChangeEvent<T>>());
readonly onDidChangeTreeCheckbox: Event<vscode.TreeCheckboxChangeEvent<T>> = this._onDidChangeTreeCheckbox.event;
private _onDidChangeCheckboxState = this._register(new Emitter<vscode.TreeCheckboxChangeEvent<T>>());
readonly onDidChangeCheckboxState: Event<vscode.TreeCheckboxChangeEvent<T>> = this._onDidChangeCheckboxState.event;

private _onDidChangeData: Emitter<TreeData<T>> = this._register(new Emitter<TreeData<T>>());

Expand Down Expand Up @@ -504,7 +504,7 @@ class ExtHostTreeView<T> extends Disposable {
item.treeItem.checkboxState = item.newState ? TreeItemCheckboxState.Checked : TreeItemCheckboxState.Unchecked;
});

this._onDidChangeTreeCheckbox.fire({ items: items.map(item => [item.extensionItem, item.newState]) });
this._onDidChangeCheckboxState.fire({ items: items.map(item => [item.extensionItem, item.newState]) });
}

async handleDrag(sourceTreeItemHandles: TreeItemHandle[], treeDataTransfer: vscode.DataTransfer, token: CancellationToken): Promise<vscode.DataTransfer | undefined> {
Expand Down
2 changes: 1 addition & 1 deletion src/vscode-dts/vscode.proposed.treeItemCheckbox.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ declare module 'vscode' {
/**
* An event to signal that an element or root has either been checked or unchecked.
*/
onDidChangeTreeCheckbox: Event<TreeCheckboxChangeEvent<T>>;
onDidChangeCheckboxState: Event<TreeCheckboxChangeEvent<T>>;
}

export interface TreeCheckboxChangeEvent<T> {
Expand Down

0 comments on commit 42e8544

Please sign in to comment.