Merge pull request #175016 from microsoft/sandy081/still-gerbil

fix #174919
microsoft · Feb 21, 2023 · 492e7d5 · 492e7d5
2 parents 08026f8 + 6305dda
commit 492e7d5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/vs/workbench/contrib/logs/common/defaultLogLevels.ts b/src/vs/workbench/contrib/logs/common/defaultLogLevels.ts
@@ -94,7 +94,7 @@ class DefaultLogLevelsService implements IDefaultLogLevelsService {
 
 	private async _writeLogLevelsToArgv(logLevels: ParsedArgvLogLevels): Promise<void> {
 		const logLevelsValue: string[] = [];
-		if (logLevels.default) {
+		if (!isUndefined(logLevels.default)) {
 			logLevelsValue.push(LogLevelToString(logLevels.default));
 		}
 		for (const [extension, logLevel] of logLevels.extensions ?? []) {

diff --git a/src/vs/workbench/contrib/logs/common/logsActions.ts b/src/vs/workbench/contrib/logs/common/logsActions.ts
@@ -129,7 +129,7 @@ export class SetLogLevelAction extends Action {
 	}
 
 	private getLogLevelEntries(defaultLogLevel: LogLevel, currentLogLevel: LogLevel): LogLevelQuickPickItem[] {
-		const button: IQuickInputButton = { iconClass: ThemeIcon.asClassName(Codicon.arrowSwap), tooltip: nls.localize('resetLogLevel', "Set as Default Log Level") };
+		const button: IQuickInputButton = { iconClass: ThemeIcon.asClassName(Codicon.checkAll), tooltip: nls.localize('resetLogLevel', "Set as Default Log Level") };
 		return [
 			{ label: this.getLabel(LogLevel.Trace, currentLogLevel), level: LogLevel.Trace, description: this.getDescription(LogLevel.Trace, defaultLogLevel), buttons: defaultLogLevel !== LogLevel.Trace ? [button] : undefined },
 			{ label: this.getLabel(LogLevel.Debug, currentLogLevel), level: LogLevel.Debug, description: this.getDescription(LogLevel.Debug, defaultLogLevel), buttons: defaultLogLevel !== LogLevel.Debug ? [button] : undefined },