Fixes #53270

microsoft · Jun 29, 2018 · 4991227 · 4991227
1 parent cddd061
commit 4991227
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts
@@ -426,12 +426,15 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
 	}
 
 	getAllRecommendations(): TPromise<IExtensionRecommendation[]> {
+		if (!this.proactiveRecommendationsFetched) {
+			return TPromise.as([]);
+		}
 		return TPromise.join([
 			this.getWorkspaceRecommendations(),
 			TPromise.as(this.getFileBasedRecommendations()),
 			this.getOtherRecommendations(),
 			TPromise.as(this.getKeymapRecommendations())
-		]).then(result => flatten(result));
+		]).then(result => flatten(result).filter(e => this.isExtensionAllowedToBeRecommended(e.extensionId)));
 	}
 
 	private fetchFileBasedRecommendations() {