Skip to content

Commit

Permalink
Wire up onClose method for welcome modal dialog. (#177000)
Browse files Browse the repository at this point in the history
* Wire up onClose method

* Update src/vs/workbench/contrib/welcomeDialog/browser/welcomeDialogService.ts

Co-authored-by: Joyce Er <joyce.er@microsoft.com>

* Update welcomeDialogService.ts

Remove close method.

---------

Co-authored-by: Joyce Er <joyce.er@microsoft.com>
  • Loading branch information
bhavyaus and joyceerhl committed Mar 13, 2023
1 parent e9b9394 commit 5c94e9f
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class WelcomeDialogService implements IWelcomeDialogService {

constructor(
@ILayoutService private readonly layoutService: ILayoutService,
@IInstantiationService private readonly instantiationService: IInstantiationService,) {
@IInstantiationService private readonly instantiationService: IInstantiationService) {
}

private static iconWidgetFor(icon: string) {
Expand Down Expand Up @@ -95,6 +95,7 @@ export class WelcomeDialogService implements IWelcomeDialogService {

this.disposableStore.add(this.dialog);
await this.dialog.show();
welcomeDialogItem.onClose?.();
this.disposableStore.dispose();
}
}
Expand Down

0 comments on commit 5c94e9f

Please sign in to comment.