Skip to content

Commit

Permalink
Don't block Pseudoterminal-based terminals launching without backend
Browse files Browse the repository at this point in the history
Fixes #144729
  • Loading branch information
Tyriar committed Mar 31, 2022
1 parent 6da26a9 commit 600fe33
Showing 1 changed file with 6 additions and 1 deletion.
Expand Up @@ -446,10 +446,15 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
this._xtermReadyPromise.then(async () => {
// Wait for a period to allow a container to be ready
await this._containerReadyBarrier.wait();
if (this._configHelper.config.shellIntegration?.enabled && !this.shellLaunchConfig.executable) {

// Resolve the executable ahead of time if shell integration is enabled, this should not
// be done for custom PTYs as that would cause extension Pseudoterminal-based terminals
// to hang in resolver extensions
if (!this.shellLaunchConfig.customPtyImplementation && this._configHelper.config.shellIntegration?.enabled && !this.shellLaunchConfig.executable) {
const os = await this._processManager.getBackendOS();
this.shellLaunchConfig.executable = (await this._terminalProfileResolverService.getDefaultProfile({ remoteAuthority: this.remoteAuthority, os })).path;
}

await this._createProcess();

// Re-establish the title after reconnect
Expand Down

0 comments on commit 600fe33

Please sign in to comment.