Avoid backticks (fixes #13098)

microsoft · Oct 1, 2016 · 602155b · 602155b
1 parent c968226
commit 602155b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/vs/workbench/electron-browser/actions.ts b/src/vs/workbench/electron-browser/actions.ts
@@ -521,12 +521,13 @@ export class ReportIssueAction extends Action {
 	}
 
 	private generateNewIssueUrl(baseUrl: string, name: string, version: string, commit: string, date: string, isPure: boolean, extensions:ILocalExtension[]): string {
+		// Avoid backticks, these can trigger XSS detectors. (https://github.com/Microsoft/vscode/issues/13098)
 		const osVersion = `${os.type()} ${os.arch()} ${os.release()}`;
 		const queryStringPrefix = baseUrl.indexOf('?') === -1 ? '?' : '&';
 		const body = encodeURIComponent(
 			`- VSCode Version: ${name} ${version}${isPure ? '' : ' **[Unsupported]**'} (${product.commit || 'Commit unknown'}, ${product.date || 'Date unknown'})
 - OS Version: ${osVersion}
-- Extensions: ${extensions.map(e => '`' + e.id + '`').join(', ')}
+- Extensions: ${extensions.map(e => e.id).join(', ')}
 
 Steps to Reproduce: