Skip to content

Commit

Permalink
fix error logging when willSave is aborted (#172847)
Browse files Browse the repository at this point in the history
  • Loading branch information
jrieken committed Jan 30, 2023
1 parent dc7aef1 commit 62bd5c1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class TextFileSaveParticipant extends Disposable {
const promise = saveParticipant.participate(model, context, progress, cts.token);
await raceCancellation(promise, cts.token);
} catch (err) {
this.logService.warn(err);
this.logService.error(err);

This comment has been minimized.

Copy link
@bpasero

bpasero Jan 31, 2023

Member

@sandy081 are we only supporting to render Error from logService.error? And if I use info or warn the error is not printed?

This comment has been minimized.

Copy link
@sandy081

sandy081 Feb 2, 2023

Member

Error is printed always except when log level is off. The way logging work is a log with log level is printed if it is greater or equal than the configured log level. Ref -

export enum LogLevel {

}
}

Expand Down

0 comments on commit 62bd5c1

Please sign in to comment.