Skip to content

Commit

Permalink
remote: fix port forwarding not working (#182980) (#182982)
Browse files Browse the repository at this point in the history
fix: register a remote socket factory in the shared process

Surprised this didn't fail more verbosely...

Fixes #182749
  • Loading branch information
connor4312 committed May 19, 2023
1 parent 2d416df commit 6d3fedb
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/vs/code/node/sharedProcess/sharedProcessMain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ import { UserDataAutoSyncService } from 'vs/platform/userDataSync/node/userDataA
import { ExtensionTipsService } from 'vs/platform/extensionManagement/node/extensionTipsService';
import { IMainProcessService, MainProcessService } from 'vs/platform/ipc/common/mainProcessService';
import { RemoteStorageService } from 'vs/platform/storage/common/storageService';
import { IRemoteSocketFactoryService, RemoteSocketFactoryService } from 'vs/platform/remote/common/remoteSocketFactoryService';
import { RemoteConnectionType } from 'vs/platform/remote/common/remoteAuthorityResolver';
import { nodeSocketFactory } from 'vs/platform/remote/node/nodeSocketFactory';

class SharedProcessMain extends Disposable {

Expand Down Expand Up @@ -338,6 +341,9 @@ class SharedProcessMain extends Disposable {
services.set(ISignService, new SyncDescriptor(SignService, undefined, false /* proxied to other processes */));

// Tunnel
const remoteSocketFactoryService = new RemoteSocketFactoryService();
services.set(IRemoteSocketFactoryService, remoteSocketFactoryService);
remoteSocketFactoryService.register(RemoteConnectionType.WebSocket, nodeSocketFactory);
services.set(ISharedTunnelsService, new SyncDescriptor(SharedTunnelsService));
services.set(ISharedProcessTunnelService, new SyncDescriptor(SharedProcessTunnelService));

Expand Down

0 comments on commit 6d3fedb

Please sign in to comment.