Fix strict null check

microsoft · Feb 8, 2019 · 709bf35 · 709bf35
1 parent 51305a6
commit 709bf35
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json
@@ -261,7 +261,6 @@
 		"./vs/platform/extensionManagement/node/extensionManagementService.ts",
 		"./vs/platform/extensionManagement/node/extensionManagementUtil.ts",
 		"./vs/platform/extensionManagement/node/extensionsManifestCache.ts",
-		"./vs/platform/extensionManagement/node/multiExtensionManagement.ts",
 		"./vs/platform/extensionManagement/test/electron-browser/extensionManagement.test.ts",
 		"./vs/platform/extensions/common/extensionHost.ts",
 		"./vs/platform/extensions/common/extensions.ts",
@@ -681,6 +680,7 @@
 		"./vs/workbench/services/editor/browser/codeEditorService.ts",
 		"./vs/workbench/services/editor/common/editorGroupsService.ts",
 		"./vs/workbench/services/editor/common/editorService.ts",
+		"./vs/workbench/services/extensionManagement/node/multiExtensionManagement.ts",
 		"./vs/workbench/services/extensions/common/extensionHostProtocol.ts",
 		"./vs/workbench/services/extensions/common/extensions.ts",
 		"./vs/workbench/services/extensions/common/extensionsRegistry.ts",

diff --git a/src/vs/workbench/services/extensionManagement/node/multiExtensionManagement.ts b/src/vs/workbench/services/extensionManagement/node/multiExtensionManagement.ts
@@ -209,6 +209,10 @@ export class MultiExtensionManagementService extends Disposable implements IExte
 		}
 
 		const remoteEnv = await connection.getEnvironment();
+		if (!remoteEnv) {
+			return false;
+		}
+
 		return remoteEnv.syncExtensions;
 	}
 }