Revert refactor and improve behaviour

microsoft · Nov 10, 2022 · 7ad0f0c · 7ad0f0c
1 parent 7ce375a
commit 7ad0f0c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/vs/workbench/contrib/notebook/browser/services/notebookExecutionStateServiceImpl.ts b/src/vs/workbench/contrib/notebook/browser/services/notebookExecutionStateServiceImpl.ts
@@ -109,7 +109,7 @@ export class NotebookExecutionStateService extends Disposable implements INotebo
 		if (lastRunSuccess !== undefined) {
 			const audioCuesEnabled = this._configurationService.getValue<boolean>(NotebookSetting.audioCuesEnabled);
 			if (lastRunSuccess) {
-				if (audioCuesEnabled) {
+				if (audioCuesEnabled && this._executions.size === 0) {
 					this._audioCueService.playAudioCue(AudioCue.taskCompleted);
 				}
 				this._clearLastFailedCell(notebookUri);

diff --git a/src/vs/workbench/contrib/notebook/common/notebookCommon.ts b/src/vs/workbench/contrib/notebook/common/notebookCommon.ts
@@ -926,7 +926,7 @@ export const NotebookSetting = {
 	outputLineHeight: 'notebook.outputLineHeight',
 	outputFontSize: 'notebook.outputFontSize',
 	outputFontFamily: 'notebook.outputFontFamily',
-	audioCuesEnabled: 'notebook.audioCuesEnabled'
+	audioCuesEnabled: 'notebook.audioCues.enabled'
 } as const;
 
 export const enum CellStatusbarAlignment {