Skip to content

Commit

Permalink
fixes #68849 : Screencast: Some keys do not get special treatment
Browse files Browse the repository at this point in the history
  • Loading branch information
dyc3 committed Mar 6, 2019
1 parent a7e5da4 commit 7eede97
Showing 1 changed file with 4 additions and 1 deletion.
Expand Up @@ -16,6 +16,7 @@ import { Context } from 'vs/platform/contextkey/browser/contextKeyService';
import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
import { timeout } from 'vs/base/common/async';
import { IPartService } from 'vs/workbench/services/part/common/partService';
import { KeyCode } from 'vs/base/common/keyCodes';

export class ToggleDevToolsAction extends Action {

Expand Down Expand Up @@ -192,7 +193,9 @@ export class ToggleScreencastModeAction extends Action {
const keybinding = this.keybindingService.resolveKeyboardEvent(event);
const label = keybinding.getLabel();

if (!event.ctrlKey && !event.altKey && !event.metaKey && !event.shiftKey && this.keybindingService.mightProducePrintableCharacter(event) && label) {
if (!event.ctrlKey && !event.altKey && !event.metaKey && !event.shiftKey &&
this.keybindingService.mightProducePrintableCharacter(event) && label &&
!(event.keyCode === KeyCode.Backspace || event.keyCode === KeyCode.Escape)) {
keyboardMarker.textContent += ' ' + label;
} else {
keyboardMarker.textContent = label;
Expand Down

0 comments on commit 7eede97

Please sign in to comment.