Skip to content

Commit

Permalink
Don't use toLocaleString for the Settings editor (#171881)
Browse files Browse the repository at this point in the history
Fixes #171787
  • Loading branch information
rzhao271 committed Jan 20, 2023
1 parent b688669 commit 8518810
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/preferences/browser/settingsTree.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { onUnexpectedError } from 'vs/base/common/errors';
import { Emitter, Event } from 'vs/base/common/event';
import { KeyCode } from 'vs/base/common/keyCodes';
import { Disposable, DisposableStore, dispose, isDisposable, toDisposable } from 'vs/base/common/lifecycle';
import { isIOS, language } from 'vs/base/common/platform';
import { isIOS } from 'vs/base/common/platform';
import { escapeRegExpCharacters } from 'vs/base/common/strings';
import { isDefined, isUndefinedOrNull } from 'vs/base/common/types';
import { localize } from 'vs/nls';
Expand Down Expand Up @@ -1758,7 +1758,7 @@ export class SettingNumberRenderer extends AbstractSettingRenderer implements IT

template.onChange = undefined;
template.inputBox.value = typeof dataElement.value === 'number' ?
dataElement.value.toLocaleString(language) : '';
dataElement.value.toString() : '';
template.inputBox.step = dataElement.valueType.includes('integer') ? '1' : 'any';
template.inputBox.setAriaLabel(dataElement.setting.key);
template.onChange = value => {
Expand Down

0 comments on commit 8518810

Please sign in to comment.