Merge pull request #129284 from ssigwart/noQuotes

Add doNotAddAttributeQuotes setting to disable automatic quotes
microsoft · Oct 15, 2021 · 8d70e04 · 8d70e04
2 parents b1c3c96 + ba48f5c
commit 8d70e04
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/extensions/html-language-features/package.json b/extensions/html-language-features/package.json
@@ -38,6 +38,22 @@
       "type": "object",
       "title": "HTML",
       "properties": {
+        "html.completion.attributeDefaultValue": {
+          "type": "string",
+          "scope": "resource",
+          "enum": [
+            "doublequotes",
+            "singlequotes",
+            "empty"
+          ],
+          "enumDescriptions": [
+            "%html.completion.attributeDefaultValue.doublequotes%",
+            "%html.completion.attributeDefaultValue.singlequotes%",
+            "%html.completion.attributeDefaultValue.empty%"
+          ],
+          "default": "doublequotes",
+          "description": "%html.completion.attributeDefaultValue%"
+        },
         "html.customData": {
           "type": "array",
           "markdownDescription": "%html.customData.desc%",

diff --git a/extensions/html-language-features/package.nls.json b/extensions/html-language-features/package.nls.json
@@ -28,6 +28,10 @@
 	"html.validate.scripts": "Controls whether the built-in HTML language support validates embedded scripts.",
 	"html.validate.styles": "Controls whether the built-in HTML language support validates embedded styles.",
 	"html.autoClosingTags": "Enable/disable autoclosing of HTML tags.",
+	"html.completion.attributeDefaultValue": "Controls the default value for attributes when completion is accepted.",
+	"html.completion.attributeDefaultValue.doublequotes": "Attribute value is set to \"\".",
+	"html.completion.attributeDefaultValue.singlequotes": "Attribute value is set to ''.",
+	"html.completion.attributeDefaultValue.empty": "Attribute value is not set.",
 	"html.mirrorCursorOnMatchingTag": "Enable/disable mirroring cursor on matching HTML tag.",
 	"html.mirrorCursorOnMatchingTagDeprecationMessage": "Deprecated in favor of `editor.linkedEditing`",
 	"html.hover.documentation": "Show tag and attribute documentation in hover.",

diff --git a/extensions/html-language-features/server/src/modes/htmlMode.ts b/extensions/html-language-features/server/src/modes/htmlMode.ts
@@ -26,6 +26,7 @@ export function getHTMLMode(htmlLanguageService: HTMLLanguageService, workspace:
 			if (doAutoComplete) {
 				options.hideAutoCompleteProposals = true;
 			}
+			options.attributeDefaultValue = settings.html.completion.attributeDefaultValue ?? 'doublequotes';
 
 			const htmlDocument = htmlDocuments.get(document);
 			let completionList = htmlLanguageService.doComplete2(document, position, htmlDocument, documentContext, options);