Use more standard name for markdown preview context key

microsoft · Feb 28, 2018 · 94ea10f · 94ea10f
1 parent 85d47a7
commit 94ea10f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/extensions/markdown/package.json b/extensions/markdown/package.json
@@ -155,22 +155,22 @@
 				},
 				{
 					"command": "markdown.showSource",
-					"when": "markdownPreview",
+					"when": "markdownPreviewFocus",
 					"group": "navigation"
 				},
 				{
 					"command": "markdown.refreshPreview",
-					"when": "markdownPreview",
+					"when": "markdownPreviewFocus",
 					"group": "1_markdown"
 				},
 				{
 					"command": "markdown.preview.toggleLock",
-					"when": "markdownPreview",
+					"when": "markdownPreviewFocus",
 					"group": "1_markdown"
 				},
 				{
 					"command": "markdown.showPreviewSecuritySelector",
-					"when": "markdownPreview",
+					"when": "markdownPreviewFocus",
 					"group": "1_markdown"
 				}
 			],
@@ -199,7 +199,7 @@
 				},
 				{
 					"command": "markdown.showSource",
-					"when": "markdownPreview",
+					"when": "markdownPreviewFocus",
 					"group": "navigation"
 				},
 				{
@@ -208,7 +208,7 @@
 				},
 				{
 					"command": "markdown.showPreviewSecuritySelector",
-					"when": "markdownPreview"
+					"when": "markdownPreviewFocus"
 				}
 			]
 		},

diff --git a/extensions/markdown/src/features/previewContentProvider.ts b/extensions/markdown/src/features/previewContentProvider.ts
@@ -486,6 +486,7 @@ export interface PreviewSettings {
 }
 
 export class MarkdownPreviewManager {
+	private static readonly markdownPreviewActiveContextKey = 'markdownPreviewFocus';
 
 	private previews: MarkdownPreview[] = [];
 	private readonly previewConfigurations = new PreviewConfigManager();
@@ -497,7 +498,7 @@ export class MarkdownPreviewManager {
 		private readonly logger: Logger
 	) {
 		vscode.window.onDidChangeActiveEditor(editor => {
-			vscode.commands.executeCommand('setContext', 'markdownPreview',
+			vscode.commands.executeCommand('setContext', MarkdownPreviewManager.markdownPreviewActiveContextKey,
 				editor && editor.editorType === 'webview' && editor.uri.scheme === MarkdownPreview.previewScheme);
 
 			if (editor && editor.editorType === 'texteditor') {