#14102 Remove state if null

microsoft · Oct 21, 2016 · 980fcd3 · 980fcd3
1 parent 8accf62
commit 980fcd3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/vs/workbench/browser/actions/openSettings.ts b/src/vs/workbench/browser/actions/openSettings.ts
@@ -341,12 +341,12 @@ export class DefaultSettingsEditor extends StringEditor {
 	}
 
 	private saveState() {
+		const resource = this.getResource();
+		if (DefaultSettingsEditor.VIEW_STATE.has(resource)) {
+			DefaultSettingsEditor.VIEW_STATE.delete(resource);
+		}
 		const state = this.getControl().saveViewState();
 		if (state) {
-			const resource = this.getResource();
-			if (DefaultSettingsEditor.VIEW_STATE.has(resource)) {
-				DefaultSettingsEditor.VIEW_STATE.delete(resource);
-			}
 			DefaultSettingsEditor.VIEW_STATE.set(resource, state);
 		}
 	}