Merge pull request #170183 from microsoft/tyriar/170182

Fix leaking quick fix disposables
microsoft · Dec 28, 2022 · a73e615 · a73e615
2 parents 83154d6 + ea857a4
commit a73e615
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/vs/workbench/contrib/terminal/browser/xterm/quickFixAddon.ts b/src/vs/workbench/contrib/terminal/browser/xterm/quickFixAddon.ts
@@ -86,18 +86,18 @@ export class TerminalQuickFixAddon extends Disposable implements ITerminalAddon,
 		if (commandDetectionCapability) {
 			this._registerCommandHandlers();
 		} else {
-			this._capabilities.onDidAddCapability(c => {
+			this._register(this._capabilities.onDidAddCapability(c => {
 				if (c === TerminalCapability.CommandDetection) {
 					this._registerCommandHandlers();
 				}
-			});
+			}));
 		}
-		this._quickFixService.onDidRegisterProvider(result => this.registerCommandFinishedListener(convertToQuickFixOptions(result)));
+		this._register(this._quickFixService.onDidRegisterProvider(result => this.registerCommandFinishedListener(convertToQuickFixOptions(result))));
 		for (const selector of terminalContributionService.quickFixes) {
 			this.registerCommandSelector(selector);
 		}
-		this._quickFixService.onDidRegisterCommandSelector(selector => this.registerCommandSelector(selector));
-		this._quickFixService.onDidUnregisterProvider(id => this._commandListeners.delete(id));
+		this._register(this._quickFixService.onDidRegisterCommandSelector(selector => this.registerCommandSelector(selector)));
+		this._register(this._quickFixService.onDidUnregisterProvider(id => this._commandListeners.delete(id)));
 	}
 
 	activate(terminal: Terminal): void {