-
Notifications
You must be signed in to change notification settings - Fork 27.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove proposed credentials API (#31131)
- Loading branch information
Showing
2 changed files
with
3 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -506,7 +506,7 @@ export function createApiFactory( | |
}; | ||
|
||
// namespace: credentials | ||
const credentials: typeof vscode.credentials = { | ||
const credentials = { | ||
readSecret(service: string, account: string): Thenable<string | undefined> { | ||
return extHostCredentials.readSecret(service, account); | ||
}, | ||
|
@@ -530,7 +530,6 @@ export function createApiFactory( | |
workspace, | ||
scm, | ||
debug, | ||
credentials, | ||
// types | ||
CancellationTokenSource: CancellationTokenSource, | ||
CodeLens: extHostTypes.CodeLens, | ||
|
@@ -584,8 +583,8 @@ export function createApiFactory( | |
Task: extHostTypes.Task, | ||
ConfigurationTarget: extHostTypes.ConfigurationTarget | ||
}; | ||
if (!extension.enableProposedApi) { | ||
delete api.credentials; // Instead of error to avoid #31854 | ||
if (extension.enableProposedApi && extension.isBuiltin) { | ||
api['credentials'] = credentials; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
chrmarti
Author
Contributor
|
||
} | ||
return api; | ||
}; | ||
|
what is this?