Merge pull request #200127 from microsoft/aiday/refactoringHoverFile

Refactoring the hover.ts file
microsoft · Dec 7, 2023 · bdef7fd · bdef7fd
2 parents 9bbc169 + 6fc4a88
commit bdef7fd
Show file tree

Hide file tree

Showing 8 changed files with 197 additions and 123 deletions.
diff --git a/src/vs/editor/contrib/colorPicker/browser/colorContributions.ts b/src/vs/editor/contrib/colorPicker/browser/colorContributions.ts
@@ -11,7 +11,7 @@ import { Range } from 'vs/editor/common/core/range';
 import { IEditorContribution } from 'vs/editor/common/editorCommon';
 import { ColorDecorationInjectedTextMarker } from 'vs/editor/contrib/colorPicker/browser/colorDetector';
 import { ColorHoverParticipant } from 'vs/editor/contrib/colorPicker/browser/colorHoverParticipant';
-import { ModesHoverController } from 'vs/editor/contrib/hover/browser/hover';
+import { HoverController } from 'vs/editor/contrib/hover/browser/hover';
 import { HoverStartMode, HoverStartSource } from 'vs/editor/contrib/hover/browser/hoverOperation';
 import { HoverParticipantRegistry } from 'vs/editor/contrib/hover/browser/hoverTypes';
 
@@ -56,7 +56,7 @@ export class ColorContribution extends Disposable implements IEditorContribution
 			return;
 		}
 
-		const hoverController = this._editor.getContribution<ModesHoverController>(ModesHoverController.ID);
+		const hoverController = this._editor.getContribution<HoverController>(HoverController.ID);
 		if (!hoverController) {
 			return;
 		}

diff --git a/src/vs/editor/contrib/hover/browser/contentHover.ts b/src/vs/editor/contrib/hover/browser/contentHover.ts
@@ -94,7 +94,7 @@ export class ContentHoverController extends Disposable {
 	/**
 	 * Returns true if the hover shows now or will show.
 	 */
-	public maybeShowAt(mouseEvent: IEditorMouseEvent): boolean {
+	public showsOrWillShow(mouseEvent: IEditorMouseEvent): boolean {
 		if (this._widget.isResizing) {
 			return true;
 		}