avoid innerHTML in context view, #106395

microsoft · Oct 9, 2020 · c2c3177 · c2c3177
1 parent 04b9275
commit c2c3177
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/vs/base/browser/ui/contextview/contextview.ts b/src/vs/base/browser/ui/contextview/contextview.ts
@@ -157,11 +157,9 @@ export class ContextView extends Disposable {
 				this.shadowRootHostElement = DOM.$('.shadow-root-host');
 				this.container.appendChild(this.shadowRootHostElement);
 				this.shadowRoot = this.shadowRootHostElement.attachShadow({ mode: 'open' });
-				this.shadowRoot.innerHTML = `
-					<style>
-						${SHADOW_ROOT_CSS}
-					</style>
-				`;
+				const style = document.createElement('style');
+				style.textContent = SHADOW_ROOT_CSS;
+				this.shadowRoot.appendChild(style);
 				this.shadowRoot.appendChild(this.view);
 				this.shadowRoot.appendChild(DOM.$('slot'));
 			} else {