Skip to content

Commit

Permalink
Simplify addStandardDisposableListener
Browse files Browse the repository at this point in the history
  • Loading branch information
alexdima committed Jan 14, 2017
1 parent 3d71a32 commit c34bd4a
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions src/vs/base/browser/dom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -235,21 +235,7 @@ export let addStandardDisposableListener: IAddStandardDisposableListenerSignatur
wrapHandler = _wrapAsStandardKeyboardEvent(handler);
}

node.addEventListener(type, wrapHandler, useCapture || false);
return {
dispose: function () {
if (!wrapHandler) {
// Already removed
return;
}
node.removeEventListener(type, wrapHandler, useCapture || false);

// Prevent leakers from holding on to the dom node or handler func
wrapHandler = null;
node = null;
handler = null;
}
};
return addDisposableListener(node, type, wrapHandler, useCapture);
};

export function addDisposableNonBubblingMouseOutListener(node: Element, handler: (event: MouseEvent) => void): IDisposable {
Expand Down

0 comments on commit c34bd4a

Please sign in to comment.