tests - do not retryCountOnTaskFailure playwright (#161299)

* tests - do not `retryCountOnTaskFailure` playwright * compile
microsoft · Sep 20, 2022 · ca745ee · ca745ee
1 parent a829fbb
commit ca745ee
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 14 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -69,7 +69,7 @@ jobs:
           7z.exe a .build/node_modules_cache/cache.7z -mx3 `@.build/node_modules_list.txt
 
       - name: Compile and Download
-        run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
+        run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
 
       - name: Compile Integration Tests
         run: yarn --cwd test/integration/browser compile
@@ -145,7 +145,7 @@ jobs:
         run: yarn --frozen-lockfile --network-timeout 180000
 
       - name: Compile and Download
-        run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
+        run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
 
       - name: Compile Integration Tests
         run: yarn --cwd test/integration/browser compile
@@ -216,7 +216,7 @@ jobs:
         run: yarn --frozen-lockfile --network-timeout 180000
 
       - name: Compile and Download
-        run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
+        run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
 
       - name: Compile Integration Tests
         run: yarn --cwd test/integration/browser compile
@@ -289,7 +289,7 @@ jobs:
         run: yarn --frozen-lockfile --network-timeout 180000
 
       - name: Download Playwright
-        run: DEBUG=pw:install yarn playwright-install
+        run: yarn playwright-install
 
       - name: Run Hygiene Checks
         run: yarn gulp hygiene

diff --git a/.github/workflows/monaco-editor.yml b/.github/workflows/monaco-editor.yml
@@ -53,7 +53,7 @@ jobs:
         run: yarn --frozen-lockfile --network-timeout 180000
 
       - name: Download Playwright
-        run: DEBUG=pw:install yarn playwright-install
+        run: yarn playwright-install
 
       - name: Run Monaco Editor Checks
         run: yarn monaco-compile-check

diff --git a/build/azure-pipelines/common/installPlaywright.js b/build/azure-pipelines/common/installPlaywright.js
@@ -4,6 +4,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 Object.defineProperty(exports, "__esModule", { value: true });
+process.env.DEBUG = 'pw:install'; // enable logging for this (https://github.com/microsoft/playwright/issues/17394)
 const retry_1 = require("./retry");
 const { installDefaultBrowsersForNpmInstall } = require('playwright-core/lib/server');
 async function install() {

diff --git a/build/azure-pipelines/common/installPlaywright.ts b/build/azure-pipelines/common/installPlaywright.ts
@@ -3,6 +3,8 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+process.env.DEBUG='pw:install'; // enable logging for this (https://github.com/microsoft/playwright/issues/17394)
+
 import { retry } from './retry';
 const { installDefaultBrowsersForNpmInstall } = require('playwright-core/lib/server');
 

diff --git a/build/azure-pipelines/darwin/product-build-darwin-test.yml b/build/azure-pipelines/darwin/product-build-darwin-test.yml
@@ -12,9 +12,7 @@ steps:
   - script: |
       set -e
       VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \
-        DEBUG=pw:install yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install"
-    timeoutInMinutes: 5
-    retryCountOnTaskFailure: 3
+        yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install"
     displayName: Download Electron and Playwright
 
   - ${{ if eq(parameters.VSCODE_RUN_UNIT_TESTS, true) }}:

diff --git a/build/azure-pipelines/linux/product-build-linux-client-test.yml b/build/azure-pipelines/linux/product-build-linux-client-test.yml
@@ -12,9 +12,7 @@ steps:
   - script: |
       set -e
       VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \
-        DEBUG=pw:install yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install"
-    timeoutInMinutes: 5
-    retryCountOnTaskFailure: 3
+        yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install"
     displayName: Download Electron and Playwright
 
   - ${{ if eq(parameters.VSCODE_QUALITY, 'oss') }}:

diff --git a/build/azure-pipelines/win32/product-build-win32-test.yml b/build/azure-pipelines/win32/product-build-win32-test.yml
@@ -13,9 +13,7 @@ steps:
       . build/azure-pipelines/win32/exec.ps1
       $ErrorActionPreference = "Stop"
       $env:VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)"
-      exec { $env:DEBUG = "pw:install"; yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" }
-    timeoutInMinutes: 5
-    retryCountOnTaskFailure: 3
+      exec { yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" }
     displayName: Download Electron and Playwright
 
   - ${{ if eq(parameters.VSCODE_RUN_UNIT_TESTS, true) }}: