remove empty cancel callback from promise constructions #56137

src/vs/base/common/async.ts

@@ -68,7 +68,7 @@ export function asThenable<T>(callback: () => T | TPromise<T> | Thenable<T>): Th
 		} else {
 			resolve(item);
 		}
-	}, () => { /* not supported */ });
+	});
 }
 
 export interface ITask<T> {
@@ -136,8 +136,6 @@ export class Throttler {
 
 			return new TPromise((c, e) => {
 				this.queuedPromise.then(c, e);
-			}, () => {
-				// no-op
 			});
 		}
 
@@ -287,8 +285,6 @@ export class Barrier {
 		this._isOpen = false;
 		this._promise = new TPromise<boolean>((c, e) => {
 			this._completePromise = c;
-		}, () => {
-			console.warn('You should really not try to cancel this ready promise!');
 		});
 	}
 
@@ -712,11 +708,11 @@ export class RunOnceWorker<T> extends RunOnceScheduler {
 export function nfcall(fn: Function, ...args: any[]): TPromise;
 export function nfcall<T>(fn: Function, ...args: any[]): TPromise<T>;
 export function nfcall(fn: Function, ...args: any[]): any {
-	return new TPromise((c, e) => fn(...args, (err: any, result: any) => err ? e(err) : c(result)), () => null);
+	return new TPromise((c, e) => fn(...args, (err: any, result: any) => err ? e(err) : c(result)));
 }
 
 export function ninvoke(thisArg: any, fn: Function, ...args: any[]): TPromise;
 export function ninvoke<T>(thisArg: any, fn: Function, ...args: any[]): TPromise<T>;
 export function ninvoke(thisArg: any, fn: Function, ...args: any[]): any {
-	return new TPromise((c, e) => fn.call(thisArg, ...args, (err: any, result: any) => err ? e(err) : c(result)), () => null);
+	return new TPromise((c, e) => fn.call(thisArg, ...args, (err: any, result: any) => err ? e(err) : c(result)));
 }

src/vs/base/common/worker/simpleWorker.ts

@@ -94,8 +94,6 @@ class SimpleWorkerProtocol {
 		let result = new TPromise<any>((c, e) => {
 			reply.c = c;
 			reply.e = e;
-		}, () => {
-			// Cancel not supported
 		});
 		this._pendingReplies[req] = reply;
 
@@ -235,7 +233,7 @@ export class SimpleWorkerClient<T> extends Disposable {
 		this._lazyProxy = new TPromise<T>((c, e) => {
 			lazyProxyFulfill = c;
 			lazyProxyReject = e;
-		}, () => { /* no cancel */ });
+		});
 
 		// Send initialize message
 		this._onModuleLoaded = this._protocol.sendMessage(INITIALIZE, [
@@ -277,8 +275,6 @@ export class SimpleWorkerClient<T> extends Disposable {
 			this._onModuleLoaded.then(() => {
 				this._protocol.sendMessage(method, args).then(c, e);
 			}, e);
-		}, () => {
-			// Cancel intentionally not supported
 		});
 	}
 

src/vs/base/node/pfs.ts

@@ -19,7 +19,7 @@ export function readdir(path: string): TPromise<string[]> {
 }
 
 export function exists(path: string): TPromise<boolean> {
-	return new TPromise(c => fs.exists(path, c), () => { });
+	return new TPromise(c => fs.exists(path, c));
 }
 
 export function chmod(path: string, mode: number): TPromise<boolean> {
@@ -194,4 +194,4 @@ export function whenDeleted(path: string): TPromise<void> {
 
 export function copy(source: string, target: string): TPromise<void> {
 	return nfcall(extfs.copy, source, target);
-}
+}

src/vs/platform/extensionManagement/node/extensionManagementService.ts

@@ -885,7 +885,7 @@ export class ExtensionManagementService extends Disposable implements IExtension
 	}
 
 	private toNonCancellablePromise<T>(promise: TPromise<T>): TPromise<T> {
-		return new TPromise((c, e) => promise.then(result => c(result), error => e(error)), () => this.logService.debug('Request Cancelled'));
+		return new TPromise((c, e) => promise.then(result => c(result), error => e(error)));
 	}
 
 	private reportTelemetry(eventName: string, extensionData: any, duration: number, error?: Error): void {

src/vs/workbench/parts/debug/node/terminals.ts

@@ -55,7 +55,7 @@ export function getDefaultTerminalLinuxReady(): TPromise<string> {
 			}
 
 			c('xterm');
-		}, () => { });
+		});
 	}
 	return _DEFAULT_TERMINAL_LINUX_READY;
 }

src/vs/workbench/parts/execution/electron-browser/terminal.ts

@@ -32,7 +32,7 @@ export function getDefaultTerminalLinuxReady(): TPromise<string> {
 			}
 
 			c('xterm');
-		}, () => { });
+		});
 	}
 	return _DEFAULT_TERMINAL_LINUX_READY;
 }

src/vs/workbench/parts/tasks/common/problemMatcher.ts

@@ -1088,7 +1088,7 @@ class ProblemPatternRegistryImpl implements IProblemPatternRegistry {
 				}
 				resolve(undefined);
 			});
-		}, () => { });
+		});
 	}
 
 	public onReady(): TPromise<void> {
@@ -1642,7 +1642,7 @@ class ProblemMatcherRegistryImpl implements IProblemMatcherRegistry {
 				}
 				resolve(undefined);
 			});
-		}, () => { });
+		});
 	}
 
 	public onReady(): TPromise<void> {

src/vs/workbench/parts/tasks/common/taskDefinitionRegistry.ts

@@ -107,7 +107,7 @@ class TaskDefinitionRegistryImpl implements ITaskDefinitionRegistry {
 				}
 				resolve(undefined);
 			});
-		}, () => { });
+		});
 	}
 
 	public onReady(): TPromise<void> {