Merge pull request #158140 from jeanp413/fix-155030

Fixes extension contributed submenus missing
microsoft · Aug 15, 2022 · f7c7130 · f7c7130
2 parents 1a582f7 + 8b46432
commit f7c7130
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/vs/workbench/services/actions/common/menusExtensionPoint.ts b/src/vs/workbench/services/actions/common/menusExtensionPoint.ts
@@ -707,20 +707,20 @@ submenusExtensionPoint.setHandler(extensions => {
 		for (const [, submenuInfo] of Object.entries(value)) {
 
 			if (!schema.isValidSubmenu(submenuInfo, collector)) {
-				return;
+				continue;
 			}
 
 			if (!submenuInfo.id) {
 				collector.warn(localize('submenuId.invalid.id', "`{0}` is not a valid submenu identifier", submenuInfo.id));
-				return;
+				continue;
 			}
 			if (_submenus.has(submenuInfo.id)) {
 				collector.info(localize('submenuId.duplicate.id', "The `{0}` submenu was already previously registered.", submenuInfo.id));
-				return;
+				continue;
 			}
 			if (!submenuInfo.label) {
 				collector.warn(localize('submenuId.invalid.label', "`{0}` is not a valid submenu label", submenuInfo.label));
-				return;
+				continue;
 			}
 
 			let absoluteIcon: { dark: URI; light?: URI } | ThemeIcon | undefined;