Skip to content

Commit

Permalink
smoke tests mitigation for issue 157979 (#157980)
Browse files Browse the repository at this point in the history
  • Loading branch information
bpasero committed Aug 12, 2022
1 parent e7360ef commit f8ad3a1
Showing 1 changed file with 24 additions and 2 deletions.
26 changes: 24 additions & 2 deletions test/smoke/src/areas/workbench/data-loss.test.ts
Expand Up @@ -8,7 +8,18 @@ import { Application, ApplicationOptions, Logger, Quality } from '../../../../au
import { createApp, timeout, installDiagnosticsHandler, installAppAfterHandler, getRandomUserDataDir, suiteLogsPath, suiteCrashPath } from '../../utils';

export function setup(ensureStableCode: () => string | undefined, logger: Logger) {
describe('Data Loss (insiders -> insiders)', () => {
describe('Data Loss (insiders -> insiders)', function () {

// There are cases where `exitApplication` does not actually
// stop the application and our attempt then to `kill` the
// process tree results in data loss / state loss. All these
// tests here rely on state getting persisted properly, so
// until we have figured out the root cause, we retry these
// tests.
// See: https://github.com/microsoft/vscode/issues/157979
if (process.platform === 'darwin') {
this.retries(2);
}

let app: Application | undefined = undefined;

Expand Down Expand Up @@ -130,7 +141,18 @@ export function setup(ensureStableCode: () => string | undefined, logger: Logger
}
});

describe('Data Loss (stable -> insiders)', () => {
describe('Data Loss (stable -> insiders)', function () {

// There are cases where `exitApplication` does not actually
// stop the application and our attempt then to `kill` the
// process tree results in data loss / state loss. All these
// tests here rely on state getting persisted properly, so
// until we have figured out the root cause, we retry these
// tests.
// See: https://github.com/microsoft/vscode/issues/157979
if (process.platform === 'darwin') {
this.retries(2);
}

let insidersApp: Application | undefined = undefined;
let stableApp: Application | undefined = undefined;
Expand Down

0 comments on commit f8ad3a1

Please sign in to comment.