Skip to content

Commit

Permalink
Renames option for a bit more clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
Eric Amodio authored and eamodio committed Mar 10, 2020
1 parent a8130a0 commit feb42fa
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/vs/workbench/browser/parts/views/viewPaneContainer.ts
Expand Up @@ -345,7 +345,7 @@ export abstract class ViewPane extends Pane implements IView {
}

if (this.progressIndicator === undefined) {
this.progressIndicator = this.instantiationService.createInstance(CompositeProgressIndicator, assertIsDefined(this.progressBar), this.id, this.isVisible(), { hideWhenInactive: true });
this.progressIndicator = this.instantiationService.createInstance(CompositeProgressIndicator, assertIsDefined(this.progressBar), this.id, this.isVisible(), { exclusiveProgressBar: true });
}
return this.progressIndicator;
}
Expand Down
Expand Up @@ -198,7 +198,7 @@ export class CompositeProgressIndicator extends CompositeScope implements IProgr
progressbar: ProgressBar,
scopeId: string,
isActive: boolean,
private readonly options: { hideWhenInactive?: boolean } | undefined,
private readonly options: { exclusiveProgressBar?: boolean } | undefined,
@IViewletService viewletService: IViewletService,
@IPanelService panelService: IPanelService,
@IViewsService viewsService: IViewsService
Expand All @@ -212,7 +212,7 @@ export class CompositeProgressIndicator extends CompositeScope implements IProgr
onScopeDeactivated(): void {
this.isActive = false;

if (this.options?.hideWhenInactive) {
if (this.options?.exclusiveProgressBar) {
this.progressbar.stop().hide();
}
}
Expand Down Expand Up @@ -314,7 +314,7 @@ export class CompositeProgressIndicator extends CompositeScope implements IProgr
done: () => {
this.progressState = ProgressIndicatorState.Done;

if (this.isActive || this.options?.hideWhenInactive) {
if (this.isActive || this.options?.exclusiveProgressBar) {
this.progressbar.stop().hide();
}
}
Expand Down Expand Up @@ -345,7 +345,7 @@ export class CompositeProgressIndicator extends CompositeScope implements IProgr
// The while promise is either null or equal the promise we last hooked on
this.progressState = ProgressIndicatorState.None;

if (this.isActive || this.options?.hideWhenInactive) {
if (this.isActive || this.options?.exclusiveProgressBar) {
this.progressbar.stop().hide();
}
}
Expand Down

0 comments on commit feb42fa

Please sign in to comment.