Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall hook not executing #100323

Closed
alberto-bc opened this issue Jun 16, 2020 · 0 comments
Closed

Uninstall hook not executing #100323

alberto-bc opened this issue Jun 16, 2020 · 0 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release extensions Issues concerning extensions verified Verification succeeded
Milestone
June 2020 Recovery 3

Comments

@alberto-bc
Copy link

  • VSCode Version: 1.46.0
  • OS Version: Windows 10/macOS Catalina 10.15.4

VS Code 1.46 no longer executes the uninstall hook

test-0.0.1.zip

Attached test extension (rename file extension to .vsix) which creates a file on uninstall in the user's home directory.
Using VS Code 1.45.1 the file is created on both Windows and macOS.
Using VS Code 1.46 no file is created.

Steps to Reproduce:

  1. Install attached extension
  2. Uninstall extension
  3. Quit VS Code
  4. Start VS Code again
  5. No file is created

Does this issue occur when all extensions are disabled?: This is an extension management problem
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Jul 17, 2020
@sandy081 sandy081 added this to the July 2020 milestone Jul 17, 2020
@sandy081 sandy081 added the candidate Issue identified as probable candidate for fixing in the next release label Jul 20, 2020
@sandy081 sandy081 reopened this Jul 20, 2020
sandy081 added a commit that referenced this issue Jul 20, 2020
@sandy081
Fix #100323
b0dd050
This was referenced Jul 20, 2020
Closed
Merged
@sandy081 sandy081 mentioned this issue Jul 20, 2020
Closed
joaomoreno pushed a commit that referenced this issue Jul 21, 2020
@sandy081 @joaomoreno
Fix #100323
9c346db
@roblourens roblourens added the verified Verification succeeded label Jul 23, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Milestone
June 2020 Recovery 3
Development

Successfully merging a pull request may close this issue.

Await until the uninstall hook is finished before removing extension microsoft/vscode
4 participants
@roblourens @sandy081 @alberto-bc and others