Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how process is managed when the terminal is reused #100709

Closed
Tyriar opened this issue Jun 21, 2020 · 0 comments · Fixed by #118574
Closed

Improve how process is managed when the terminal is reused #100709

Tyriar opened this issue Jun 21, 2020 · 0 comments · Fixed by #118574
Assignees
@Tyriar
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2020

Currently TerminalInstance gets asked to reuse a terminal by tasks at which point it does a bunch of things similar to regular startup but it's a different code path that's difficult to manage. Ideally this would restart a regular process not having to duplicate launch logic. Maybe this could be hidden inside TerminalProcessManager and its promises become events with better current state tracking?
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Jun 21, 2020
@Tyriar Tyriar added this to the Backlog milestone Jun 21, 2020
@Tyriar Tyriar self-assigned this Jun 21, 2020
@Tyriar Tyriar mentioned this issue Mar 9, 2021
Closed
Tyriar added a commit that referenced this issue Mar 9, 2021
@Tyriar
Move some ptyProcessReady usage inside proc manager
7f94f0d 
Part of #100709
@Tyriar Tyriar mentioned this issue Mar 9, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Make terminal relaunch logic more internal to the process manager microsoft/vscode
2 participants
@Tyriar and others