Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts for new notebook UI #101436

Closed
davidanthoff opened this issue Jun 30, 2020 · 7 comments
Closed

Keyboard shortcuts for new notebook UI #101436

davidanthoff opened this issue Jun 30, 2020 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality notebook verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@davidanthoff
Copy link
Contributor

Is there going to be a uniform keyboard shortcut story for the new notebook UI, or is the idea that every extension configures its own keyboard shortcuts?

If there is something uniform, has the choice of keyboard shortcuts been settled? If yes, is there a place where we can look at the current choices?

We are currently redesigning the keyboard shortcut choices generally inside the Julia extension, and we would like to make sure that the code execution shortcuts we use outside of the notebook UI are aligned with whatever will come via notebook support once it lands.

@rebornix
Copy link
Member

@davidanthoff we are going to introduce builtin keyboard shortcuts, which will be similar to the keybindings for text editor, e.g., Copy/Move Line, Delete Line, Insert Line Above/Below.

@rebornix rebornix added feature-request Request for new features or functionality notebook labels Jun 30, 2020
@rebornix rebornix added this to the July 2020 milestone Jun 30, 2020
@rebornix rebornix added the debt Code quality issues label Jun 30, 2020
@davidanthoff
Copy link
Contributor Author

Cool! And I take it that the final set of keyboard shortcuts has not been set yet, right? We're particularly interested in the set of shortcuts that will execute cells.

@rebornix
Copy link
Member

Currently we have following execute related commands/keybindings for macOS

{ "key": "ctrl+enter",            "command": "notebook.cell.execute",
                                     "when": "notebookEditorFocused" },
{ "key": "alt+enter",             "command": "notebook.cell.executeAndInsertBelow",
                                     "when": "notebookEditorFocused" },
{ "key": "shift+enter",           "command": "notebook.cell.executeAndSelectBelow",
                                     "when": "notebookEditorFocused" },
{ "command: "notebook.execute" }

@davidanthoff
Copy link
Contributor Author

How final do you think they are? Should we better wait with our keyboard redesign until this is all settled? I think if there is a non-negligible probability that this is not yet final, we would probably be better off waiting with our general redesign until the notebook stuff has shipped.

@rebornix
Copy link
Member

@davidanthoff I'll suggest you wait for us to finalize (shipping to Stable) before you redesign the keybindings. Next month we will roll in more keybindings and you can start looking into that and see how much gap between the builtin ones and the ones you have in mind for Julia.

@davidanthoff
Copy link
Contributor Author

Ok, perfect, that was exactly the kind of info I was looking for!

@rebornix
Copy link
Member

rebornix commented Jul 6, 2020

404eb11 updated commonly used keybindings for notebooks @davidanthoff you can open Keybindings Editor and search for Notebook.

@rebornix rebornix removed the debt Code quality issues label Jul 6, 2020
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 8, 2020
@rebornix rebornix added the verification-needed Verification of issue is requested label Aug 4, 2020
@connor4312 connor4312 added the verified Verification succeeded label Aug 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants