Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy/paste cell issues #101462

Closed
roblourens opened this issue Jun 30, 2020 · 3 comments
Closed

Copy/paste cell issues #101462

roblourens opened this issue Jun 30, 2020 · 3 comments
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
July 2020

Comments

@roblourens
Copy link
Member

roblourens commented Jun 30, 2020 •
edited

  • Execute a github issue cell
  • Copy the cell, paste it below
  • The output picker shows up, but the output doesn't
  • Scroll around, sometimes the second output is visible when the first cell is not visible
  • Delete the first cell
  • Scroll the second cell in and out, now the output is visible

My guess is that there are outputs with the same outputId
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Jun 30, 2020
@roblourens roblourens added this to the July 2020 milestone Jun 30, 2020
@rebornix
Copy link
Member

rebornix commented Jun 30, 2020 •
edited

cc @connor4312 . For copy paste, we should only copy raw outputs instead of processed outputs.

@roblourens roblourens changed the title Copy/paste cell with webview output issues Copy/paste cell issues Jul 1, 2020
@roblourens
Copy link
Member Author

Also it looks like we end up with a cell with the same handle, which leads to other issues, like 'selection' is not updated in the EH if I select that cell

roblourens added a commit that referenced this issue Jul 1, 2020
@roblourens
Comment out part of test - see #101462
43a1026
@roblourens
Copy link
Member Author

It looks like this is fixed

@connor4312 connor4312 mentioned this issue Aug 6, 2020
Closed
@connor4312 connor4312 added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
3 participants
@roblourens @rebornix @connor4312