Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MD preview previews markdown notebook cells #101514

Closed
jrieken opened this issue Jul 1, 2020 · 3 comments
Closed

MD preview previews markdown notebook cells #101514

jrieken opened this issue Jul 1, 2020 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Milestone
July 2020

Comments

@jrieken
Copy link
Member

jrieken commented Jul 1, 2020

  • open a markdown file
  • open the markdown preview to its side
  • replace the markdown file with a notebook
  • in the notebook edit a markdown cell
  • 馃悰 the markdown preview previews the cell

Screenshot 2020-07-01 at 17 17 44

@kieferrm had demoed this issue before and I am unsure if a duplicate exists or not...
@jrieken
Copy link
Member Author

jrieken commented Jul 1, 2020

I believe what's happening is that the cell editor is becoming the active editor (in API term) and the the markdown preview panel reacts on that. I think that generally makes sense but only for editors that have a view column. @mjbvz is there a reason why the preview work on any editor?

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Jul 1, 2020
@mjbvz mjbvz added this to the July 2020 milestone Jul 1, 2020
@mjbvz mjbvz closed this as completed in 3a54cd7 Jul 6, 2020
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 8, 2020
@mjbvz @gjsjohnmurray
Disable markdown commands when in markdown cells in notebooks
bc6f524 
Fixes microsoft#101514
@roblourens
Copy link
Member

If I change the 'when' clause of the command to open the markdown preview to remove !notebookEditorFocused, I can still open a preview of a markdown cell. Is that a problem? Seems ok, I specifically asked for it.

@roblourens roblourens added the verified Verification succeeded label Aug 6, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Aug 6, 2020

Yes, I think that's fine. I gated the automatic previewing of files to always be disabled in notebooks. I didn't do the same for the command since the when clause seemed like a better approach

@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
4 participants
@roblourens @jrieken @mjbvz and others