Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks: Broken subpixel AA #101607

Open
joaomoreno opened this issue Jul 2, 2020 · 1 comment
Open

Notebooks: Broken subpixel AA #101607

joaomoreno opened this issue Jul 2, 2020 · 1 comment
Assignees
@roblourens
Labels
debt Code quality issues notebook-layout
Milestone
Backlog

Comments

@joaomoreno
Copy link
Member

Open a Notebook on Light+ theme.

image
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Jul 2, 2020
@roblourens roblourens added this to the July 2020 milestone Jul 2, 2020
@roblourens roblourens added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Jul 2, 2020
@roblourens
Copy link
Member

Hm, I fixed this but subpixel AA is still broken in markdown content. It works in the monaco editor in either case. If I get rid of the webview, it works for markdown.

It seems like contain: strict is responsible for making this work in monaco. I'm trying to apply the same fix to markdown cells in the notebook and it's not working (but I don't really think that's the right fix anyway). @rebornix wondering whether you know anything about this?

@roblourens roblourens reopened this Jul 7, 2020
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 8, 2020
@roblourens @gjsjohnmurray
Remove transparent styling on notebook list
4933a2d 
Fix microsoft#101607
@roblourens roblourens modified the milestones: July 2020, August 2020 Aug 3, 2020
@roblourens roblourens modified the milestones: August 2020, September 2020 Sep 2, 2020
@roblourens roblourens modified the milestones: September 2020, Backlog Sep 29, 2020
@rebornix rebornix removed the notebook label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
debt Code quality issues notebook-layout
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @rebornix @tanhakabir