Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks steal focus on explorer select #101622

Closed
JacksonKearl opened this issue Jul 2, 2020 · 3 comments
Closed

Notebooks steal focus on explorer select #101622

JacksonKearl opened this issue Jul 2, 2020 · 3 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
August 2020

Comments

@JacksonKearl
Copy link
Contributor

  1. create a new .github-issues notebook. It should have a single, empty github-issues cell by default.
  2. close the editor, then click on it again from explorer.
  3. 馃悰 Focus goes to editor
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Jul 2, 2020
@roblourens roblourens modified the milestones: June 2020, July 2020 Jul 2, 2020
roblourens added a commit that referenced this issue Jul 8, 2020
@roblourens
馃拕 #101622
8b1be08
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 8, 2020
@roblourens @gjsjohnmurray
Don't steal focus when restoring notebook editor state
01894c5 
Fix microsoft#101622
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 8, 2020
@roblourens @gjsjohnmurray
馃拕 microsoft#101622
f99f854
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 9, 2020
@roblourens @gjsjohnmurray
Don't steal focus when restoring notebook editor state
af1fefd 
Fix microsoft#101622
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 9, 2020
@roblourens @gjsjohnmurray
馃拕 microsoft#101622
f474d1a
@JacksonKearl JacksonKearl added the verification-found Issue verification failed label Aug 5, 2020
@JacksonKearl
Copy link
Contributor Author

Still seeing this... whenever the file is empty, clicking on it will steal focus.
recording

@JacksonKearl JacksonKearl reopened this Aug 5, 2020
@roblourens roblourens modified the milestones: July 2020, August 2020 Aug 6, 2020
@roblourens roblourens removed the verification-found Issue verification failed label Aug 6, 2020
@roblourens
Copy link
Member

For some reason, the empty cell we insert by default steals focus. But @rebornix do we want to get rid of that default cell now that the toolbar exists for an empty editor?

@roblourens
Copy link
Member

I see https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts#L654, I think ideally it would only do that if the notebook is focused, but the notebook doesn't know whether it's going to be focused when it's opening, and when it gets focused, it doesn't know if it just got opened. I'm going to delete this for now.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
4 participants
@roblourens @RMacfarlane @JacksonKearl and others