Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: should indent after simple jsx tag with attributes #101922

Closed
alexr00 opened this issue Jul 8, 2020 · 2 comments
Closed

Test failure: should indent after simple jsx tag with attributes #101922

alexr00 opened this issue Jul 8, 2020 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders integration-test-failure verified Verification succeeded
Milestone
January 2021

Comments

@alexr00
Copy link
Member

alexr00 commented Jul 8, 2020

This test has failed twice for me today:
https://dev.azure.com/vscode/VSCode/_build/results?buildId=48153&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=d494b5db-eef8-5766-984e-01186010c86f
mjbvz added a commit that referenced this issue Jul 8, 2020
@mjbvz
Add slight delay to test
76471bd 
For #101922

I can't repo this locally but suspect it may be timing related
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Jul 9, 2020
@mjbvz @gjsjohnmurray
Add slight delay to test
2518465 
For microsoft#101922

I can't repo this locally but suspect it may be timing related
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 22, 2020
@joaomoreno joaomoreno added this to the January 2021 milestone Jan 7, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Jan 15, 2021 •
edited

This was likely caused by the TS extension not being activated when the test was run

@mjbvz mjbvz closed this as completed in 308a4f6 Jan 15, 2021
@Tyriar
Copy link
Member

Tyriar commented Jan 28, 2021

@mjbvz not the best fix, timeouts are inherently flaky and this seems to adds .5s to the whole test suite?

@Tyriar Tyriar added the verified Verification succeeded label Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders integration-test-failure verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
6 participants
@joaomoreno @bpasero @Tyriar @mjbvz @alexr00 and others