Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encodedSemanticClassifications-full does not request cancellation when completions are requested #102161

Open
sheetalkamat opened this issue Jul 10, 2020 · 2 comments
Assignees
Labels
debt Code quality issues javascript JavaScript support issues perf typescript Typescript support issues
Milestone

Comments

@sheetalkamat
Copy link
Member

  • VSCode Version:
  • OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

Found this while investigating microsoft/TypeScript#35364 which turns out that semantic colorization takes approximately 10s but completions are quick with or without that request but seem to take longer as colorization is not cancelled.

@mjbvz mjbvz assigned mjbvz and unassigned jrieken Jul 10, 2020
@mjbvz mjbvz added this to the Backlog milestone Jul 10, 2020
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues perf typescript Typescript support issues labels Jul 10, 2020
@mjbvz mjbvz added the debt Code quality issues label Oct 16, 2020
chenjigeng pushed a commit to chenjigeng/vscode that referenced this issue Nov 22, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Mar 3, 2022

I investigated this a while back but a full fix turned out to be quite complicated (mainly because we need to first cancel and then re-queue the request)

5942862 makes it so that these requests are canceled whenever the document changes. So if the user is relying on quick-suggestions while typing, these requests should already be getting canceled. However they could still hit an issue if they simple trigger suggestions without typing. I think this is acceptable given the complexity of a complete fix

@mjbvz mjbvz closed this as completed Mar 3, 2022
@mjbvz mjbvz added the wont-fix label Mar 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2022
@mjbvz
Copy link
Contributor

mjbvz commented Nov 16, 2022

Reopening based on TS team's desire the prioritize this

@mjbvz mjbvz reopened this Nov 16, 2022
@microsoft microsoft unlocked this conversation Nov 16, 2022
@mjbvz mjbvz removed bug Issue identified by VS Code Team member as probable bug wont-fix labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues javascript JavaScript support issues perf typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

3 participants