Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost login status after each update #103675

Closed
llk2yq opened this issue Jul 31, 2020 · 5 comments
Closed

Lost login status after each update #103675

llk2yq opened this issue Jul 31, 2020 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster settings-sync

Comments

@llk2yq
Copy link

llk2yq commented Jul 31, 2020

Issue Type: Bug

After each update, I need to log back in to the sync extension.

VS Code version: Code - Insiders 1.48.0-insider (15ada62, 2020-07-30T14:46:01.621Z)
OS version: Darwin x64 19.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2600)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 8, 8, 6
Memory (System) 16.00GB (2.63GB free)
Process Argv -psn_0_680102 --crash-reporter-id f5ea5240-bf6c-4a3a-ae71-140382dfde1f
Screen Reader no
VM 0%
Extensions (15)
Extension Author (truncated) Version
vscode-eslint dba 2.1.8
uniapp-snippet dlh 0.0.2
gitlens eam 10.2.2
EditorConfig Edi 0.15.1
prettier-vscode esb 5.1.3
code-runner for 0.11.0
todo-tree Gru 0.0.178
dotenv mik 1.0.1
vscode-language-pack-zh-hans MS- 1.48.1
korofileheader OBK 4.7.2
vetur oct 0.25.0
vue-vscode-snippets sdr 1.9.0
vscodeintellicode Vis 1.2.9
vscode-icons vsc 10.2.0
material-theme zhu 3.8.5
@sandy081
Copy link
Member

sandy081 commented Aug 4, 2020

Are you seeing the number badge on account icon and asking to sign in?

Which account are you using?

@sandy081 sandy081 added info-needed Issue requires more information from poster settings-sync labels Aug 4, 2020
@sandy081 sandy081 added this to the July 2020 milestone Aug 4, 2020
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Aug 4, 2020
@sandy081
Copy link
Member

sandy081 commented Aug 4, 2020

I can also reproduce this and I am sure that this caused by this #103238

Root cause is that there is no deterministic way to know if the required auth providers are registered are not. Hence this causing a race condition while updating auth token.

Hence, I would like to revert the change in #103238 wait until #103507 is implemented.

@llk2yq
Copy link
Author

llk2yq commented Aug 8, 2020

I used to use Github account , and in Last two months. I'm using MS account now, and in latest version(2020-08-07T05:30:01.305Z) ,this problem still exists.

@sandy081
Copy link
Member

sandy081 commented Aug 9, 2020

Can you please provide the Settings Sync logs from output view when it happens?

@sandy081 sandy081 reopened this Aug 9, 2020
@sandy081 sandy081 added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders labels Aug 9, 2020
@sandy081 sandy081 removed this from the July 2020 milestone Aug 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster settings-sync
Projects
None yet
Development

No branches or pull requests

3 participants
@sandy081 @llk2yq and others