Ability to use settings sync when one of the account extensions is disabled

[sandy081]

As a user I would like to disable one of the Microsoft Account or Github Authentication extensions and I can still use Settings Sync.

[sandy081]

To verify, before turning on settings sync

• disable any of the auth (Microsoft/Github) account extensions
• Make sure Turn on Settings Sync action is still available and you can turn on sync

Note: There is a separate issue to track disallowing disabling auth extension if settings sync is using it - #103405

[sandy081]

Reverting this feature because of

#103675
#103501

Proper fix needs Settings Sync feature to know until when to wait for the required auth providers are registered which depends on - #103507

[sandy081]

To verify, before turning on settings sync

• disable any of the auth (Microsoft/Github) account extensions
• Make sure Turn on Settings Sync action is still available and you can turn on sync
• When both extensions are disabled, Turn on Settings Sync action is not available.

[lszomoru]

@sandy081, I have disabled both auth extensions yet I am still seeing the Turn on Settings Sync in the Gear and Accounts menus as well as in the command palette. Based on the verification steps that does not seem to be expected. Running Insiders:

Version: 1.49.0-insider
Commit: 00754e4
Date: 2020-09-02T05:43:25.834Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 20.0.0

[sandy081]

Good catch !!!. You shall see the action, not showing the action might confuse users. Instead an error is thrown while turning on sync.

[sandy081]

New steps to verify, before turning on settings sync

• disable any of the auth (Microsoft/Github) account extensions
• Make sure Turn on Settings Sync action is still available and you can turn on sync
• When both extensions are disabled, turning on settings sync action fails with an error.

Note: There is a known issue #105955 if you turn on sync after enabling the auth extension.