Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick open actions become always visible after opening explorer context menu #103681

Closed
joaomoreno opened this issue Jul 31, 2020 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

  1. Open quick open, all is good
  2. Right click in Explorer to open the context menu
  3. Open quick open, all actions are visible

image

Bug is somewhere in this CSS which overwrites the display: none quick open depends on:

.monaco-action-bar .action-item .icon,
.monaco-action-bar .action-item .codicon {
display: inline-block;
}
.monaco-action-bar .action-item .codicon {
display: flex;
align-items: center;
}

I thought all that CSS was only meant for the shadow DOM, shouldn't all of that be properly scoped?

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Jul 31, 2020
@sbatten
Copy link
Member

sbatten commented Jul 31, 2020

for menus that do not use shadow dom like global menu, we push this css to a shared top-level element in the dom. I'm not sure why this is happening now since this css exists in actionbar.css as well, but I will scope mine to monaco-menu as a fix

@sbatten sbatten added this to the July 2020 milestone Jul 31, 2020
annkamsk pushed a commit to annkamsk/vscode that referenced this issue Aug 3, 2020
@joaomoreno joaomoreno added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@joaomoreno @sbatten and others