Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"copy/paste cell" should not copy metadata #103881

Closed
roblourens opened this issue Aug 3, 2020 · 4 comments
Closed

"copy/paste cell" should not copy metadata #103881

roblourens opened this issue Aug 3, 2020 · 4 comments
Assignees
@roblourens @rebornix
Labels
notebook-clipboard under-discussion Issue is under discussion for relevance, priority, approach
Milestone
January 2023

Comments

@roblourens
Copy link
Member

  • Execute a github issue cell
  • Copy/paste the cell
  • The new cell has the same run state metadata, it should actually have the default new cell metadata
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Aug 3, 2020
@roblourens roblourens added this to the August 2020 milestone Aug 3, 2020
@rebornix
Copy link
Member

rebornix commented Aug 3, 2020

This is interesting, I guess we should only copy custom metadata and leave others default?

@roblourens
Copy link
Member Author

I dunno, or maybe it's a case for run state metadata just being different. Or actually, should it copy the outputs as well? Then this metadata would make sense

@roblourens
Copy link
Member Author

But not if it's in the "running" state. Uhhhh

@roblourens roblourens mentioned this issue Aug 6, 2020
Closed
rebornix added a commit that referenced this issue Aug 13, 2020
@rebornix
Re #103881.
35a1137
rebornix added a commit that referenced this issue Aug 13, 2020
@rebornix
re #103881.
dde1372
@rebornix
Copy link
Member

I made a few changes to copy/paste cells. We will only copy metadata which are not execution related, e.g., editable, runnable, etc. execution_count, lastRunDuration, etc are now treated in the same way as outputs.

@rebornix rebornix added under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug labels Aug 13, 2020
@rebornix rebornix modified the milestones: August 2020, Backlog Sep 1, 2020
@gjsjohnmurray gjsjohnmurray mentioned this issue Feb 4, 2021
Closed
@rebornix rebornix mentioned this issue Dec 14, 2022
Closed
2 tasks
rebornix added a commit that referenced this issue Dec 14, 2022
@rebornix
Fix #103881. Skip metadata when copying cells.
e5308a0
@rebornix rebornix modified the milestones: Backlog, January 2023 Dec 14, 2022
rebornix added a commit that referenced this issue Dec 14, 2022
@rebornix
Fix #103881. Skip metadata when copying cells. (#169183)
2ca44a8
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
notebook-clipboard under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
5 participants
@roblourens @rebornix @DonJayamanne and others