Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot overwrite read only files anymore #104651

Closed
Sumo-MBryant opened this issue Aug 14, 2020 · 4 comments
Closed

Cannot overwrite read only files anymore #104651

Sumo-MBryant opened this issue Aug 14, 2020 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-io File I/O regression Something that used to work is now broken verified Verification succeeded
Milestone
July 2020 Recovery

Comments

@Sumo-MBryant
Copy link

On previous versions of VSCode (1.47) you received a message when attempting to save a file that was marked read only:

image

As of 1.48, you receive a different message that lacks an overwrite option:

image

When a file is simply marked as read only, retrying as admin is not an appropriate option and fails to resolve the issue.

Please restore Overwrite functionality as it is very useful for us that use archaic source control systems that rely on making files read only.

  • VSCode Version: 1.48.0
  • OS Version: Windows 10 (1903)

Steps to Reproduce:

  1. Open a file with the read only flag set
  2. Make a change to the file
  3. Save the file

Does this issue occur on the latest insiders build?: Yes
Does this issue occur when all extensions are disabled?: Yes
@bpasero bpasero self-assigned this Aug 14, 2020
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken labels Aug 14, 2020
@bpasero bpasero added this to the July 2020 Recovery milestone Aug 14, 2020
@bpasero
Copy link
Member

bpasero commented Aug 14, 2020

Thanks, a regression we can probably fix for recovery.

bpasero added a commit that referenced this issue Aug 14, 2020
@bpasero
Cannot overwrite read only files anymore (#104651)
b3ec3fb
bpasero added a commit that referenced this issue Aug 14, 2020
@bpasero
Cannot overwrite read only files anymore #104651
711fdf9
@bpasero bpasero mentioned this issue Aug 14, 2020
Merged
@bpasero bpasero added the file-io File I/O label Aug 14, 2020
@crysyn
Copy link

crysyn commented Aug 15, 2020

Was just about to post this as well. This changed about 3-4 weeks back in VSCode Insiders as well if that time frame helps.

bpasero added a commit that referenced this issue Aug 17, 2020
@bpasero
Cannot overwrite read only files anymore #104651 (#104654)
7a84d56
@bpasero bpasero closed this as completed Aug 17, 2020
@gjsjohnmurray gjsjohnmurray mentioned this issue Aug 17, 2020
Closed
@isidorn
Copy link
Contributor

isidorn commented Aug 19, 2020

Works great, I have verified the fix on windows with read-only files.

@isidorn isidorn added the verified Verification succeeded label Aug 19, 2020
@isidorn isidorn mentioned this issue Aug 20, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release file-io File I/O regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
July 2020 Recovery
Development

No branches or pull requests
5 participants
@bpasero @crysyn @isidorn @Sumo-MBryant and others