Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: Cmd+Down no longer moves focus to editor #104783

Closed
bpasero opened this issue Aug 17, 2020 · 7 comments
Closed

Explorer: Cmd+Down no longer moves focus to editor #104783

bpasero opened this issue Aug 17, 2020 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 17, 2020

  • OS Version: macOS

Steps to Reproduce:

  1. open a file with the mouse
  2. press Cmd+ArrowDown

=> 馃悰 focus does not move into editor

Works fine if you arrow down first to another file.

@bpasero bpasero added the file-explorer Explorer widget issues label Aug 17, 2020
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 17, 2020
@isidorn
Copy link
Contributor

isidorn commented Aug 17, 2020

Thanks for opening this, I can repro.
Assignign to August so we fix this.

@isidorn isidorn added this to the August 2020 milestone Aug 17, 2020
@isidorn
Copy link
Contributor

isidorn commented Aug 18, 2020

Same as #104373
Had to introdcue a new command that gets also triggered in this case. Since the list.onDidOpen does not trigger if the focus did not change. @joaomoreno maybe we should consider changing that and remove all of this unuseful commands which we introduced

@bpasero bpasero added the verification-found Issue verification failed label Sep 1, 2020
@bpasero bpasero reopened this Sep 1, 2020
@bpasero
Copy link
Member Author

bpasero commented Sep 1, 2020

It works but I would expect the selection in the explorer to also then be there.

@isidorn
Copy link
Contributor

isidorn commented Sep 1, 2020

@bpasero can you please clarify what you meant?

@bpasero
Copy link
Member Author

bpasero commented Sep 1, 2020

@isidorn when I Cmd+Down, the item that opens is not the selected one in the explorer

@isidorn
Copy link
Contributor

isidorn commented Sep 1, 2020

That is how we always operated. Cmd+Down works on tree focus, not on selection.

@bpasero
Copy link
Member Author

bpasero commented Sep 1, 2020

Ah ok, then maybe this was changed a while ago. I confirmed that Enter is also not moving the selection, which I personally find strange but if no-one else complains, fine.

My rationale is that Enter and Cmd+Down should behave exactly like a mouse-click but moving focus into the editor.

@bpasero bpasero closed this as completed Sep 1, 2020
@bpasero bpasero added verified Verification succeeded and removed verification-found Issue verification failed labels Sep 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@joaomoreno @bpasero @isidorn and others