Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #104299 #104373

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Fixes #104299 #104373

merged 1 commit into from
Aug 10, 2020

Conversation

joaomoreno
Copy link
Member

This PR fixes #104299 for release 1.48

@joaomoreno joaomoreno added the candidate Issue identified as probable candidate for fixing in the next release label Aug 10, 2020
@joaomoreno joaomoreno added this to the July 2020 milestone Aug 10, 2020
@joaomoreno joaomoreno self-assigned this Aug 10, 2020
@isidorn
Copy link
Contributor

isidorn commented Aug 10, 2020

Looks good, I tested it and works nicely.
As a follow up I have created this issue for references #104374

@joaomoreno joaomoreno merged commit fdd1492 into release/1.48 Aug 10, 2020
@joaomoreno joaomoreno deleted the joao/release/1.48/104299 branch August 10, 2020 17:48
@isidorn isidorn mentioned this pull request Aug 18, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn approved these changes

Assignees

@joaomoreno joaomoreno

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaomoreno @isidorn