Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

overflowWidgetsDomNode and onDidBlurEditorWidget don't work together #105346

Closed
jrieken opened this issue Aug 25, 2020 · 3 comments
Closed

overflowWidgetsDomNode and onDidBlurEditorWidget don't work together #105346

jrieken opened this issue Aug 25, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Aug 25, 2020

  • open GH issue notebook
  • select F2 (rename) on a variable
  • 馃悰 widget shows, widget hides

The underlying problem is that the rename widget is rooted under the overflowContent-node, e.g not within the editor node, and that causes the editor to loose widget focus as soon as the rename widget gets focus (and in return the rename widget closes because the editor has lost widget focus...)

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug notebook labels Aug 25, 2020
rebornix added a commit that referenced this issue Aug 27, 2020
@alexdima alexdima added this to the August 2020 milestone Sep 2, 2020
@alexdima
Copy link
Member

alexdima commented Sep 4, 2020

The adoption of overflowWidgetsDomNode was temporarily rolled back in the Notebook editors via 3428992 . Let's try to tackle this in September.

@joaomoreno
Copy link
Member

Let's move this to cleanup month: October.

@joaomoreno
Copy link
Member

Closing since the issue doesn't repro no more.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook
Projects
None yet
Development

No branches or pull requests

4 participants