Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support enable/disable on SelectActionViewItem #105543

Open
Tyriar opened this issue Aug 27, 2020 · 1 comment
Open

Support enable/disable on SelectActionViewItem #105543

Tyriar opened this issue Aug 27, 2020 · 1 comment
Assignees
@lramos15
Labels
dropdown DropDown (SelectBox widget) native and custom issues feature-request Request for new features or functionality
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 27, 2020

Right now SelectActionViewItem.updateEnabled is not implemented which means disabling the associated action does not disable the select box.
@Tyriar Tyriar added the dropdown DropDown (SelectBox widget) native and custom issues label Aug 27, 2020
Tyriar added a commit that referenced this issue Aug 27, 2020
@Tyriar
Don't hide switch terminal dropdown when proc not supported
a9204aa 
This was causing it not to show up when processes become supported
later. Ideally the dropdown would be disabled like other action views
but this will be done as part of #105543.
@isidorn
Copy link
Contributor

isidorn commented Aug 28, 2020

This makes sense. However I do not own the dropdown. We should find an owner for it. Let me know if there are volunteeres.

@isidorn isidorn removed their assignment Aug 28, 2020
@Tyriar Tyriar self-assigned this Aug 28, 2020
@Tyriar Tyriar added this to the Backlog milestone Aug 28, 2020
@Tyriar Tyriar added the feature-request Request for new features or functionality label Aug 28, 2020
@isidorn isidorn assigned JacksonKearl and unassigned Tyriar Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lramos15 lramos15

Labels
dropdown DropDown (SelectBox widget) native and custom issues feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@isidorn @Tyriar @lramos15 @JacksonKearl