Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook diff: reverting changes does not update diff view #105917

Closed
isidorn opened this issue Sep 2, 2020 · 2 comments
Closed

Notebook diff: reverting changes does not update diff view #105917

isidorn opened this issue Sep 2, 2020 · 2 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
August 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 2, 2020

Testing #105770

  1. Open my-work.github-issues from the vscode repository and make some changes to it
  2. Open in SCM diff view. Click on the Revert button
  3. Changes get reverted, however what is shown is stale (it still shows the file as changed)

Compare how this works nicer for regualr files, where on revert the diff view gets auto updated.
@sana-ajani
Copy link
Contributor

seeing the same thing, changes are gone from SCM view but the open file is not changed or reverted.

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Sep 2, 2020
rebornix added a commit that referenced this issue Sep 2, 2020
@rebornix
re #105917. update dirty state
355fbca
@rebornix rebornix added this to the August 2020 milestone Sep 2, 2020
rebornix added a commit that referenced this issue Sep 2, 2020
@rebornix
re #105917.
e0cc75a
This was referenced Sep 2, 2020
Closed
Closed
@isidorn isidorn added the verified Verification succeeded label Sep 3, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Sep 3, 2020

Works nice now, thanks for fixing.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

No branches or pull requests
4 participants
@rebornix @isidorn @sana-ajani and others