Groovy syntax highlighting not automatically applied for files named Jenkinsfile

[joshbolduc]

Issue Type: Bug

Repro steps:

1. Open a file named Jenkinsfile

Expect:
Groovy file mode is detected automatically (worked in 1.48)

Actual:
File is detected as plain text (as of 1.49)

It looks like this change removed "filenames": [ "Jenkinsfile" ] from the groovy extension, presumably inadvertently. By way of comparison, the docker extension has both a filenames entry for Dockerfile and a pattern:

vscode/extensions/docker/package.json

Lines 16 to 17 in b91c581

	"filenames": [ "Dockerfile", "Containerfile" ],
	"filenamePatterns": [ "Dockerfile.*", "Containerfile.*" ],

So I'm inferring that the fix would be to restore the deleted line and also retain the new pattern, which would make everyone happy. (Or as happy as they can be writing Jenkinsfiles, anyway.)

VS Code version: Code - Insiders 1.50.0-insider (e13875b, 2020-09-15T05:35:57.362Z)
OS version: Windows_NT x64 10.0.18363

Extensions: none

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Support for .jenkinsfile extension and Jenkinsfile.* filename pattern (#105325)
• Support for .jenkinsfile extension and Jenkinsfile.* filename pattern (#105326)