Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate list/tree keyboardSupport option #107011

Closed
joaomoreno opened this issue Sep 18, 2020 · 4 comments
Closed

Deprecate list/tree keyboardSupport option #107011

joaomoreno opened this issue Sep 18, 2020 · 4 comments
Assignees
@rebornix
Labels
debt Code quality issues
Milestone
September 2020

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Sep 18, 2020 •
edited

The keyboardSupport list/tree option exists in order for the widget to handle keyboard events itself. There should be no use for this in the workbench any more since keyboard events should be handled by the keybinding service, enabling custom keyboard shortcuts.

There are currently two usages:

Could you review this flag in your use case and let me know why you would need it?

Thanks!
@joaomoreno joaomoreno added the debt Code quality issues label Sep 18, 2020
@joaomoreno joaomoreno added this to the September 2020 milestone Sep 18, 2020
@alexdima
Copy link
Member

This is my workaround for the stopPropagation() -- b89779e

alexr00 added a commit that referenced this issue Sep 21, 2020
@alexr00
Remove keyboard support from remote explorer help
708bc7d 
Part of #107011
@alexr00
Copy link
Member

alexr00 commented Sep 21, 2020

It isn't needed in the HelpPanel. Removed!

@alexr00 alexr00 removed their assignment Sep 21, 2020
meganrogge pushed a commit to meganrogge/vscode that referenced this issue Sep 22, 2020
@alexr00 @meganrogge
Remove keyboard support from remote explorer help
ccd8fc5 
Part of microsoft#107011
@joaomoreno
Copy link
Member Author

Ping @rebornix

@joaomoreno joaomoreno removed their assignment Sep 30, 2020
rebornix added a commit that referenced this issue Sep 30, 2020
@rebornix
re #107011.
1463659
@rebornix
Copy link
Member

It's no longer needed in comment list, thanks!

meganrogge pushed a commit that referenced this issue Oct 1, 2020
@rebornix @meganrogge
re #107011.
696fb61
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
debt Code quality issues
Projects
None yet
Milestone
September 2020
Development

No branches or pull requests
4 participants
@joaomoreno @rebornix @alexdima @alexr00