Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selection to next Find match does not work with Regex Find Mode #107090

Open
a-guy-on-the-internet opened this issue Sep 20, 2020 · 6 comments · May be fixed by #136582
Open

Add selection to next Find match does not work with Regex Find Mode #107090

a-guy-on-the-internet opened this issue Sep 20, 2020 · 6 comments · May be fixed by #136582
Assignees
@rebornix @alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations editor-multicursor Editor multiple cursor issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Milestone
Backlog

Comments

@a-guy-on-the-internet
Copy link

Description

Adding selection to next find match does not work when the regex find mode is turned on. I am not sure this is intended, but based on #5715 I would assume you would want this to work along with adding everything to the selection so I'm calling it a bug.

I made an example of this in the gif below while in an instance with extensions disabled by running code --disable-extensions and with me just trying to add to the selection using ctrl+d

VscodeRegexctrld

Version Info

VSCode Version: 1.48.2 (system setup)
Commit: a047975
Date: 2020-08-25T10:13:11.295Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. Open any document with some text
  2. Turn on the regex mode for the search tool
  3. Add some valid regex pattern
  4. Attempt to add another cursor by pressing ctrl+d

Does this issue occur when all extensions are disabled?: Yes
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug editor-multicursor Editor multiple cursor issues editor-find Editor find operations labels Oct 8, 2020
@rebornix rebornix added this to the On Deck milestone Oct 12, 2020
@rebornix rebornix added the help wanted Issues identified as good community contribution opportunities label Oct 12, 2020
@rebornix rebornix assigned alexdima and unassigned rebornix Nov 6, 2020
@rebornix rebornix removed this from the On Deck milestone Nov 6, 2020
@alexdima alexdima added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities labels Nov 20, 2020
@alexdima alexdima added this to the Backlog milestone Nov 20, 2020
@theo-bittencourt
Copy link

Happy birthday Miss Requested Feature! 1 year old.
Just kidding. I'd like to see this small but charming feature caming to life.
Seems like the Miss is just waiting for a Code Knight, or there are one already PR to it?

@rebornix rebornix self-assigned this Oct 11, 2021
@hediet hediet added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Oct 19, 2021
@Letiste
Copy link

Letiste commented Nov 6, 2021

Hello, I would like to work on this issue. I'm new to the codebase, could you give me some tips on where to look at?

@Letiste
Copy link

Letiste commented Nov 6, 2021

Okay, it was straightforward ^^ I will do the PR today

@Letiste Letiste linked a pull request Nov 6, 2021 that will close this issue
Open
@kevin-lindsay-1
Copy link

kevin-lindsay-1 commented Jun 17, 2022 •
edited

I honestly didn't realize that this was a bug, I just thought I was using VS Code wrong, because it seemed like there should be a command to do this, because select all works. Crazy that select next doesn't work.

Welp, I guess I gotta get repetitive strain injury now from having to do all of these matches 1 at a time (because I can't use select all for what I need to do, only certain sets).

@Gephery Gephery mentioned this issue Sep 18, 2022
Open
@Naitreey
Copy link

Naitreey commented Feb 4, 2023 •
edited

Sorry to spam. I felt the same as @kevin-lindsay-1 . Didn't expect this kind of inconsistency. Hope this gets resolved sooner.

@amunger amunger mentioned this issue Dec 14, 2023
Closed
BrunoSoaresEngineering added a commit to BrunoSoaresEngineering/vscode that referenced this issue Apr 27, 2024
@BrunoSoaresEngineering
fix: find match not working in Regex Find mode (microsoft#107090)
5411a79
BrunoSoaresEngineering added a commit to BrunoSoaresEngineering/vscode that referenced this issue Apr 27, 2024
@BrunoSoaresEngineering
test: add microsoft#107090 case
afa6269
Open
@BrunoSoaresEngineering
Copy link
Contributor

Hi @rebornix @alexdima,

I've just open a PR to solve this issue: #211550. May you kindly have a look?

Thanks a lot in advance for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebornix rebornix

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations editor-multicursor Editor multiple cursor issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix: find next match selection regex Letiste/vscode
9 participants
@theo-bittencourt @rebornix @hediet @alexdima @Naitreey @kevin-lindsay-1 @a-guy-on-the-internet @Letiste @BrunoSoaresEngineering